chore(tests): assert Firefox manifest warnings only in dedicated tests by suveshmoza · Pull Request #2696 · wxt-dev/wxt

suveshmoza · 2026-10-26T17:41:07Z

Overview

Asserted Firefox missing data_collection_permissions and extension-id warning in their own tests. Suppressed both warnings for the rest of the test suite, so they no longer log them. A test can still turn either warning back on.

Manual Testing

cd packages/wxt
bun run test run e2e/tests/zip.test.ts
bun run test run e2e/tests/hooks.test.ts
bun run test run e2e/tests/output-structure.test.ts
bun run test run e2e/tests/manifest-content.test.ts
bun run test run src/internal/__tests__/manifest.test.ts

Related Issue

This PR closes #2693

Signed-off-by: Suvesh Moza <[email protected]>

netlify · 2026-10-26T17:41:16Z

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	`6e6d554`
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6ae580979f662938de8bc128
😎 Deploy Preview	https://deploy-preview-2696--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai · 2026-10-26T17:41:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: cf93be17-97b5-4ff6-bd11-60dc88d2c18e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

nishu-murmu · 2026-10-27T05:43:02Z

@suveshmoza
you're just adding tests and telling us to run bun run test
please provide a proper way for us to test this feature manually?

if this is firefox extension related issue, what to do exactly? how do we test this manually?

suveshmoza · 2026-10-27T07:27:49Z

@nishu-murmu Since this change spans the e2e test suite, I initially mentioned bun run test. I've updated the PR description with more specific test commands.

The change suppresses the warning across the test suite, and we explicitly verify that the warning is handled correctly in a dedicated test case.

nishu-murmu · 2026-10-27T09:04:06Z

You still didn't get what I'm trying to convey
I don't want to run some tests to check whether this works or not

I want to manually create this scenario and implement this firefoxDataCollection to true so that I'll be able to check.
Running just tests doesn't provide much insights

can you tell me how can spin up the extension (locally) for this particular scenario and able to test this warnings?

suveshmoza · 2026-10-27T15:46:18Z

Build wxt-demo (or a new project) for Firefox. WXT will log warnings for both missing fields. Then set suppressWarnings.firefoxDataCollection and/or suppressWarnings.firefoxId to true in wxt.config.ts, or provide values for the missing fields, WXT will no longer log warning.

nishu-murmu · 2026-10-28T05:07:40Z

Also the PR naming convention is not correct! Please follow the guidelines!

pkg-pr-new · 2026-10-28T10:25:09Z

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2696

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2696

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2696

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2696

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2696

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2696

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2696

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2696

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2696

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2696

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2696

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2696

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2696

wxt

npm i https://pkg.pr.new/wxt@2696

commit: 6f11565

codecov · 2026-10-28T10:25:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.44%. Comparing base (8fb1f6d) to head (6f11565).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
+ Coverage   80.32%   80.44%   +0.12%     
==========================================
  Files         139      139              
  Lines        4162     4162              
  Branches      961      961              
==========================================
+ Hits         3343     3348       +5     
+ Misses        720      716       -4     
+ Partials       99       98       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

PatrykKuniczak · 2026-10-30T22:27:49Z

@suveshmoza But maybe better idea is to generate those values instead of supressing it?

suveshmoza · 2026-11-03T19:17:19Z

@PatrykKuniczak Suppressing these warnings in e2e tests, as there are no related test cases. They’re better suited for unit tests, where we generate the relevant scenario and verify that the warning is logged. https://github.com/wxt-dev/wxt/pull/2696/changes#diff-c798978929d3e3cb8a7f34c9604fa1d1c83c1524b1a98fcfdd703ec0e273d147

test(wxt): assert Firefox manifest warnings only in dedicated tests

257bcd7

Signed-off-by: Suvesh Moza <[email protected]>

suveshmoza requested review from PatrykKuniczak, aklinker1 and nishu-murmu as code owners October 26, 2026 17:41

github-actions Bot assigned suveshmoza Oct 26, 2026

github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Oct 26, 2026

Merge branch 'main' into test/firefox-manifest-warnings

6f11565

nishu-murmu changed the title ~~test(wxt): assert Firefox manifest warnings only in dedicated tests~~ chore(tests): assert Firefox manifest warnings only in dedicated tests Oct 28, 2026

Merge branch 'main' into test/firefox-manifest-warnings

6e6d554

Navigation Menu

Repository navigation

chore(tests): assert Firefox manifest warnings only in dedicated tests - #2696

chore(tests): assert Firefox manifest warnings only in dedicated tests#2696
suveshmoza wants to merge 3 commits into
wxt-dev:mainfrom
suveshmoza:test/firefox-manifest-warnings

suveshmoza commented Oct 26, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

Review skipped

Uh oh!

nishu-murmu commented Oct 27, 2026

Uh oh!

suveshmoza commented Oct 27, 2026

Uh oh!

nishu-murmu commented Oct 27, 2026 •

edited

Loading

Uh oh!

suveshmoza commented Oct 27, 2026

Uh oh!

nishu-murmu commented Oct 28, 2026

Uh oh!

pkg-pr-new Bot commented Oct 28, 2026

Uh oh!

codecov Bot commented Oct 28, 2026

Uh oh!

PatrykKuniczak commented Oct 30, 2026

Uh oh!

suveshmoza commented Nov 3, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

suveshmoza commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Manual Testing

Related Issue

Uh oh!

netlify Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for creative-fairy-df92c4 ready!

Uh oh!

coderabbitai Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nishu-murmu commented Oct 27, 2026

Uh oh!

suveshmoza commented Oct 27, 2026

Uh oh!

nishu-murmu commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suveshmoza commented Oct 27, 2026

Uh oh!

nishu-murmu commented Oct 28, 2026

Uh oh!

pkg-pr-new Bot commented Oct 28, 2026

Uh oh!

codecov Bot commented Oct 28, 2026

Codecov Report

Uh oh!

PatrykKuniczak commented Oct 30, 2026

Uh oh!

suveshmoza commented Nov 3, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

suveshmoza commented Oct 26, 2026 •

edited

Loading

netlify Bot commented Oct 26, 2026 •

edited

Loading

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

nishu-murmu commented Oct 27, 2026 •

edited

Loading